Roi Dayan

I already have this by adding description to add the preview and small js. I'm not sure it's good to force this in the class it self. maybe with an...

maybe to rename this callback type to image ? it isn't really for files but for images..

see my suggestion here https://github.com/tareq1988/wordpress-settings-api-class/pull/45

so the image type will be the same as file but with preview? I thought the file will be input type="file"

related pr #47

it's already passed as array line 153 register_setting( $section['id'], $section['id'], array( $this, 'sanitize_options' ) ); maybe you should be more specific.

I see what you mean. Not sure it's important at all. It is backward compatible to allow passing only a callback. And then it will be treated as an array...

but it also means it must use the media uploader. you won't be able to use external url.

yes so maybe i dont understand what the ticket is about. adding another field that will use attachment id?

I use the file field so user can use the media uploader or use a link. i dont want a text field here.