Rohit Sharma

Results 36 comments of Rohit Sharma

@laymonage Currently the issue is there are no hyperlinks to promoted results pages. I have tried to address this by overriding the `Column` class to add links to the page...

Thanks @laymonage, now the PR is ready for review!

@laymonage Thanks a lot, I've made the updates. Please let me know if any changes are required!

Thanks @laymonage for all the amazing feedbacks. I really enjoyed working on this. Looking forward to trying my hand on the remaining FBVs! 🙌

@RealOrangeOne I would like to give this a try. I'll really appreciate if you could provide guidance on how I can approach implementing this feature.

Thanks @RealOrangeOne, I believe we can update the **_get_redirect** method in **RedirectMiddleware** to handle wildcard redirects. https://github.com/wagtail/wagtail/blob/e97f3648c76628059da6fd7d7be6d0e102c77de5/wagtail/contrib/redirects/middleware.py#L11 I think this way we can implement the feature with minimal changes. Here's...

Thanks @RealOrangeOne, I followed your suggestions and created a draft #11628. Can you please share your thoughts on it?

Okay, if performing the wildcard matching directly in the database seems like the best approach, then i can explore that option further. Should i take #7528 as reference?

Oh okay, Could preprocessing the path potentially introduce unforeseen problems, especially if deliberate use of '*' could lead to unexpected behavior in the database? Also, I'm not aware of the...

@RealOrangeOne I completely agree with what you said. So, following your suggestion, I am holding off on this until we have proper input and thoughts from other members as well!