Rohit Verma

Results 65 comments of Rohit Verma
trafficstars

Well currently the custom selector is in xml and I am working on migrating it to the jetpack compose. So, any changes will be redundant as for now. If you...

Sure, I will ping @LachlanMajor after migration. 🙂

Hey @Vivecstel I am getting this crash: > java.lang.IllegalArgumentException: width and height must be > 0 android.graphics.Bitmap.createBitmap(Bitmap.java:1004) android.graphics.Bitmap.createBitmap(Bitmap.java:968) android.graphics.Bitmap.createBitmap(Bitmap.java:918) android.graphics.Bitmap.createBitmap(Bitmap.java:879) soup.neumorphism.internal.shape.FlatShape.toBlurredBitmap(FlatShape.kt:98) soup.neumorphism.internal.shape.FlatShape.updateShadowBitmap(FlatShape.kt:83) soup.neumorphism.NeumorphShapeDrawable.draw(NeumorphShapeDrawable.kt:283) android.view.View.getDrawableRenderNode(View.java:19441) android.view.View.drawBackground(View.java:19377) android.view.View.draw(View.java:19174) android.view.View.updateDisplayListIfDirty(View.java:18133) android.view.View.draw(View.java:18911) android.view.ViewGroup.drawChild(ViewGroup.java:4243) android.view.ViewGroup.dispatchDraw(ViewGroup.java:4029)...

Okay, I got it :) But one question. By Custom Picker, did you mean this, Mr. Nicolas? ![WhatsApp Image 2024-03-30 at 19 14 51_dcc5ec51](https://github.com/commons-app/apps-android-commons/assets/101377978/d16545cf-eb98-4bb2-aae3-7934cfdd51e6) If yes, then I would like...

Yes, I tried opening this from Nearby fragment but I got only these two options: ![WhatsApp Image 2024-03-30 at 19 37 18_a5b8b692](https://github.com/commons-app/apps-android-commons/assets/101377978/ec1abf8c-da41-4998-ab25-28cc966a04d2)

So, should we also need to allow for 1 picture to be selected from the selector that is on the screenshot I uploaded?

Okay 👍, I will start working on the current one first. Also, now I am getting the custom-selector option at the Nearby, Thanks :)

> @rohit9625 Are you still working on this? If not feel free to unassign :-) I was busy with my academics in the past days but now I have time...

Hey @nicolas-raoul , I was planning to recreate the whole custom selector using **Jetpack Compose** and optimize its performance as I mentioned in the GSoC proposal. So, if the selected...

> +1 for Jetpack Compose, if we aren't using it already. It seems to be the [official recommendation](https://developer.android.com/develop/ui/compose) for future-proof UI development. Am I good to go then?