Rohit Nayak
Rohit Nayak
> @rohit-nayak-ps I could also just remove the transaction duration (stallHandler) part and stick with the simpler heartbeat based check. This might indeed be a good path to choose, since...
> @mattlord thank you, I think we should go with this change, seeing that it's so succinct. Same here. Thanks @mattlord.
It says this in the description: >It's quite some time before that error surfaces when in this stalled state and when in the state leading up to this error you...
Fixed via issues referenced above
> I know this is still draft, but I'm wondering whether it affects `Cancel` at all? Yes, just updated description as well. https://github.com/vitessio/vitess/pull/15807/files#diff-327b08a43697d540e06dfd4e4c4d0cb617dc66f9ad3d74c451b926405c9faae5R2701
After going through the topo locking code for etcd I understood why we needed to create the `KeyspaceRoutingRules` key in the topo before we can lock. etcd itself allows a...
The watch output after changing the key paths to `/vitess/global/routing_rules/keyspace/Rules` ``` etcdctl watch "/vitess/global/routing_rules" --prefix=true PUT /vitess/global/routing_rules/sentinel ensure creation of Routing Rules root key: routing_rules PUT /vitess/global/routing_rules/locks/7668661917856618578 { "Action": "lock...
No longer needed
To clarify, the use of `Version` is not causing a functional issue in Vitess, right? This change is only to be consistent? Since we are watching a specific key, it...
I checked out your branch. I seem to see `Version` and `ModRevision` still used inconsistently. What am I missing? Since no test is failing, I am assuming we don't really...