Rohit Nayak
Rohit Nayak
Thanks for this, @beingnoble03 . I wanted to note that this PR doesn't fix https://github.com/vitessio/vitess/issues/12092 entirely. These have not been addressed: ``` * Add validations to check that incompatible flags...
Adding backport to 18.0 as suggested above, at least for the core logic fix. Will address the nits along with the suggested addition to test coverage in follow-up tests, so...
Replaced with https://github.com/vitessio/vitess/pull/15503
Wondering if changing the generated column query to something like, will help, in case the issue is with how MySQL internally processes json for generated columns. ``` CREATE TABLE `orders`...
> Hi @rohit-nayak-ps, I am new to this codebase and I would love to contribute, may I pick this up? Sure, we are always happy to have new contributors! I...
> @rohit-nayak-ps I'd like to work on this issue. Could you please assign it to me if no one does? Assigned, thanks for volunteering.
You can feel free to work on it. However this requires some basic knowledge of Vitess, so only attempt it if you have got a working installation of Vitess and...
Thanks for checking. We found a separate issue with MySQL JSON datatypes for arbitrary precision numeric/decimal data. I have a fix in progress for that. I will create a PR...
With the stall detection enabled, I was a bit concerned that we were creating many goroutines, since we are creating one for every transaction? So I added some logging (https://github.com/vitessio/vitess/commit/98cb46242f1d719cabe191a3c842ecb38fbb9cd9)...
A couple of thoughts here: * Can we perform the stall check around the query execute(s)? Or is there a good reason to have this separate handler-based mechanism? * Instead...