Rohit Gohri

Results 115 comments of Rohit Gohri

@mrseanryan Can add that to the "postinstall" script to run it automatically

> ``` > Could not get diff from git between master and HEAD > { Error: Command failed: git diff master...HEAD > fatal: ambiguous argument 'master...HEAD': unknown revision or path...

> Danger local isn't for using on CI - that's what `danger pr` is for But that skips for non PRs, is there any way to run danger for non...

> Then yeah, that's what you'll need to set up - master in that repo needs to represent the before, and the current branch as the merged master Yeah, just...

> However, we are using develop branch as the primary branch, not master. Does anyone know how to resolve the issue? There is a `--base` option for danger local. You...

We could publish to Github instead https://github.com/features/package-registry ?

It's coming from `@accounts/graphql-api` ``` Error: Cannot find module '@accounts/magic-link' Require stack: - /project/node_modules/@accounts/graphql-api/lib/modules/accounts-magic-link/index.js - /project/node_modules/@accounts/graphql-api/lib/modules/accounts/index.js - /project/node_modules/@accounts/graphql-api/lib/modules/index.js - /project/node_modules/@accounts/graphql-api/lib/index.js ```

API_KEY needs to be 32 chars: https://github.com/CachetHQ/Docker/issues/330#issuecomment-490574998 This fixed it for me

Cool. I'll try my hand at it this week

So, I had a look at this. And I realised the reason I wanted this was to cover the issues that get closed without an associated PR, like with commits...