Robinhood icon indicating copy to clipboard operation
Robinhood copied to clipboard

Published 20 hours ago • verified publisher icon rohanpai

Added features

Open dsouzarc opened this issue 9 years ago • 3 comments

Added some more features and methods to Robinhood.py, and adapted example.py to showcase a few of those features.

Also organized the code and added comments to both Robinhood.py and example.py

Updated the README.md to reflect those changes and provide more details

dsouzarc avatar May 05 '15 23:05 dsouzarc

Made the recommended changes

dsouzarc avatar May 06 '15 10:05 dsouzarc

:+1: @dsouzarc looks good, combine changes into one commit and let's merge this!

rohanpai avatar May 07 '15 17:05 rohanpai

I have an issue with the use of raw_input which is CLI and Python 2 bias (raw_input removed in Python3). IMO, the API should require a symbol and let a new CLI module handle arguments and/or input.

Also, is there a reason why session, username, password, etc are done as class variables rather than instance variables? The latter seems much more reasonable because if you create more than one instance of this class, things will get weird :)

iamseth avatar May 07 '15 19:05 iamseth