gohack icon indicating copy to clipboard operation
gohack copied to clipboard

cmdget: accept package paths

Open josharian opened this issue 5 years ago • 9 comments

Fixes #62

josharian avatar Oct 02 '19 20:10 josharian

Hey, @rogpeppe. No prob if you're busy, but it'd be nice to know what kind of response time I should expect on PRs and issues. It'll help me gauge how I want to slot in gohack work amongst my other obligations. (And might you also want to add Paul or Daniel as owners?)

josharian avatar Oct 07 '19 16:10 josharian

@josharian My github notifications are broken, it seems. Your reply there was the first email I got. Will review asap.

rogpeppe avatar Oct 07 '19 20:10 rogpeppe

Thanks for taking a look! (I don't suppose you want to also take a peek at the issues I filed here recently? :P)

Will add tests and update. Currently all tests at master are failing for me, so I'll need to investigate first why.

josharian avatar Oct 07 '19 21:10 josharian

The test failures are due to https://github.com/rogpeppe/go-internal/issues/84.

josharian avatar Oct 07 '19 23:10 josharian

(Still working on adding tests.)

josharian avatar Oct 07 '19 23:10 josharian

Sigh. Testing this requires list support from goproxytest:

            go get golang.org/x/text: unexpected status (http://127.0.0.1:61947/mod/golang.org/x/text/@v/list): 404 Not Found

I had hoped that using Go 1.12 would allow me not to have to invest time in goproxytest in order to make progress here. Nope. :P

josharian avatar Oct 07 '19 23:10 josharian

I'd love to see this make it in

tmc avatar Jul 27 '21 23:07 tmc

Feel free to take it over! I’ve lost momentum and don’t have a pressing need for it any more.

josharian avatar Jul 28 '21 00:07 josharian

I’ll look into it. I opened a PR but the ci job didn’t seem to trigger..

On Tue, Jul 27, 2021 at 5:24 PM Josh Bleecher Snyder < @.***> wrote:

Feel free to take it over! I’ve lost momentum and don’t have a pressing need for it any more.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rogpeppe/gohack/pull/63#issuecomment-887919487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA7CJZ7QWMP7EUH2WUGD3TZ5E5RANCNFSM4I4224WA .

tmc avatar Jul 28 '21 01:07 tmc