gohack
gohack copied to clipboard
cmdget: accept package paths
Fixes #62
Hey, @rogpeppe. No prob if you're busy, but it'd be nice to know what kind of response time I should expect on PRs and issues. It'll help me gauge how I want to slot in gohack work amongst my other obligations. (And might you also want to add Paul or Daniel as owners?)
@josharian My github notifications are broken, it seems. Your reply there was the first email I got. Will review asap.
Thanks for taking a look! (I don't suppose you want to also take a peek at the issues I filed here recently? :P)
Will add tests and update. Currently all tests at master are failing for me, so I'll need to investigate first why.
The test failures are due to https://github.com/rogpeppe/go-internal/issues/84.
(Still working on adding tests.)
Sigh. Testing this requires list
support from goproxytest:
go get golang.org/x/text: unexpected status (http://127.0.0.1:61947/mod/golang.org/x/text/@v/list): 404 Not Found
I had hoped that using Go 1.12 would allow me not to have to invest time in goproxytest in order to make progress here. Nope. :P
I'd love to see this make it in
Feel free to take it over! I’ve lost momentum and don’t have a pressing need for it any more.
I’ll look into it. I opened a PR but the ci job didn’t seem to trigger..
On Tue, Jul 27, 2021 at 5:24 PM Josh Bleecher Snyder < @.***> wrote:
Feel free to take it over! I’ve lost momentum and don’t have a pressing need for it any more.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rogpeppe/gohack/pull/63#issuecomment-887919487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA7CJZ7QWMP7EUH2WUGD3TZ5E5RANCNFSM4I4224WA .