godeps icon indicating copy to clipboard operation
godeps copied to clipboard

Fetch all remotes.

Open howbazaar opened this issue 8 years ago • 4 comments

I have my remotes generally set up so origin is my repos, and upstream reflects the project's upstream repository. godeps always used to return me an error godeps had previously set the tree to be some revision that was not the tip of master. By telling git to fetch all remotes rather than just the default (origin), we bring in the upstream changes too.

howbazaar avatar Sep 18 '16 21:09 howbazaar

I have live tested this for a few weeks first. All seems to be good.

howbazaar avatar Sep 18 '16 21:09 howbazaar

I was just about to make the same change.

babbageclunk avatar Oct 07 '16 12:10 babbageclunk

Fetching all remotes seems quite heavyweight to me. I often have quite a few remotes configured (for example I've got 15 remotes for github.com/juju/juju) and I fear that this will cause fetches to take a long time.

I just checked. In that repository, "git fetch" took 2s to run, but "git fetch --all" took over 2 minutes.

For Go repositories, origin really is the best default for the main repository, as that's the remote set up by go get, and also you almost never want to do "git fetch" on your own repository unless you're changing machines.

However I appreciate that your setup isn't that uncommon. How about blessing "upstream" and doing a fetch of that too if it exists?

rogpeppe avatar Oct 07 '16 15:10 rogpeppe

That would work for me.

On 8 October 2016 4:18:33 AM NZDT, Roger Peppe [email protected] wrote:

Fetching all remotes seems quite heavyweight to me. I often have quite a few remotes configured (for example I've got 15 remotes for github.com/juju/juju) and I fear that this will cause fetches to take a long time.

I just checked. In that repository, "git fetch" took 2s to run, but "git fetch --all" took over 2 minutes.

For Go repositories, origin really is the best default for the main repository, as that's the remote set up by go get, and also you almost never want to do "git fetch" on your own repository unless you're changing machines.

However I appreciate that your setup isn't that uncommon. How about blessing "upstream" and doing a fetch of that too if it exists?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/rogpeppe/godeps/pull/4#issuecomment-252280532

Sent from my Android device with K-9 Mail. Please excuse my brevity.

howbazaar avatar Oct 08 '16 01:10 howbazaar