godef icon indicating copy to clipboard operation
godef copied to clipboard
verified publisher icon rogpeppe

vendor/ dir

Open glycerine opened this issue 9 years ago • 3 comments

I love godef, but it doesn't seem to notice when a vendor/ directory is being used.

glycerine avatar Jan 21 '17 03:01 glycerine

I ran into the same thing when using glide.

I found this PR (which was closed without merging). I followed these directions on the pull request and got vendor directories working: https://github.com/rogpeppe/godef/pull/25#issuecomment-215533341

aloucks avatar Feb 09 '17 03:02 aloucks

@aloucks helpful thankyou. I wonder why folks seem to think that #33 fixed the issue, when apparently it does not? Maybe it was re-broken.

glycerine avatar Feb 09 '17 15:02 glycerine

~I tested this by reverting to d712540 and it still didn't work, so this hasn't been broken by subsequent commits to this repository. Perhaps this has been broken by changes in more recent Go versions? I only tested against 1.8, as I don't currently have a simple way to test against previous versions.~~

~~Thoughts @rogpeppe?~~

Scratch that, it appears the package I happened to test against specifies a vanity import path, and glide does not verify this, so it happily pulled in the github repo instead, hence the import could not be found. Apologies for the noise, this functionality appears to be working fine here.

pdf avatar Mar 14 '17 23:03 pdf