go-internal icon indicating copy to clipboard operation
go-internal copied to clipboard

testscript: explore addition of io/fs.FS to Params

Open myitcv opened this issue 3 years ago • 2 comments

DO NOT SUBMIT

myitcv avatar Mar 01 '21 15:03 myitcv

The build failures are as a result of https://github.com/golang/go/issues/40067#issuecomment-782075833. So whilst not directly caused by this change, this change does exacerbate the situation.

myitcv avatar Mar 01 '21 15:03 myitcv

Per a quick chat with @mvdan, perhaps a better approach here is to walk the entire io/fs.FS for .txt files, rather than simply globbing at the root. This would work well, because the caller would be entirely in control over what is exposed via the FS.

myitcv avatar Mar 02 '21 15:03 myitcv