collapsed icon indicating copy to clipboard operation
collapsed copied to clipboard

feat: horizontal mode

Open SaidMarar opened this issue 3 years ago • 5 comments

This feature add an horizontal mode (width) to the collapser enhancement request from #81 Without collapasedWidth option expand-collapse With collapasedWidth option expand-collapse-2

SaidMarar avatar Dec 24 '22 20:12 SaidMarar

⚠️ No Changeset found

Latest commit: 3ae5a7e573ff934c644f281448ccf02370836e76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 24 '22 20:12 changeset-bot[bot]

Thanks for the PR! I'm actually working on a major refactor in #122 that will make this difficult to merge. Once that is completed, this PR will need to be rebased against it.

roginfarrer avatar Jan 03 '23 16:01 roginfarrer

Thanks for the PR! I'm actually working on a major refactor in #122 that will make this difficult to merge. Once that is completed, this PR will need to be rebased against it.

Great news @roginfarrer ! Do not worry i just read the code and it looks VERY CLEAN 😃 , i will wait for your release then i'll re-implement the horizontal mode. I left a comment in your PR check it out, do not hesitate if you need some help on refacto ;)

SaidMarar avatar Jan 03 '23 19:01 SaidMarar

Deploy Preview for react-collapsed failed.

Name Link
Latest commit 3ae5a7e573ff934c644f281448ccf02370836e76
Latest deploy log https://app.netlify.com/sites/react-collapsed/deploys/63c66b19f0c0c20008021f02

netlify[bot] avatar Jan 16 '23 15:01 netlify[bot]

Hey @roginfarrer Take a look, i just implemented it 😄

SaidMarar avatar Jan 16 '23 17:01 SaidMarar