Roger Wang

Will see this soon. Thanks for your patience.

In upstream the `webview` tag supports a limited set of events: https://developer.chrome.com/apps/tags/webview . Listening on arbitrary dom events including 'contextmenu' is viewed as undocumented usage, which unfortunately breaks when upstream...

That's to free the memory allocated in Node.js, where the malloc() call is actually done by HeapAlloc() in CRT. free() can't be used here because it's intercepted by allocator shim...

Does upstream has this bug with Chrome Apps?

This need further checking by me because the code of that function caused tricky regression in the past.

sure, will look into it soon.

We'll review this after 0.24.0 release as the PR is for nw24. Thanks.

great. I'll review this after 0.15.0 release, which is soon to be available.

Will look to merge this. On Fri, Mar 10, 2017 at 10:14 AM Dhruv Gramopadhye wrote: > Any status on this? > > — > You are receiving this because...

Thanks for the patch but it's not a correct fix -- it gives permissions to all scenarios.