gulp-ejs icon indicating copy to clipboard operation
gulp-ejs copied to clipboard

Don't use ejs.render when options.client is true

Open megakoresh opened this issue 7 years ago • 4 comments

Tried to use this to compile clientside templates, but since it uses ejs.render, it will throw an error on various undefined variables during compilation. I can't provide browser variables - the plugin should use ejs.compile if it sees options.client is set to true.

megakoresh avatar Jun 16 '17 14:06 megakoresh

@megakoresh thanks for the feedback!

If you wish to contribute a pull request is very welcome.

Anyway I can fix it, but I can't guarantee when.

rogeriopvl avatar Jun 16 '17 14:06 rogeriopvl

Done.

megakoresh avatar Jun 16 '17 15:06 megakoresh

Hello? Can you merge that thing or say why it can't be merged? I'd really rather avoid linking a fork as dependency for my project.

megakoresh avatar Jun 17 '17 08:06 megakoresh

@rogeriopvl fix pls

iiAbady avatar Jun 21 '19 04:06 iiAbady