file-stream-rotator icon indicating copy to clipboard operation
file-stream-rotator copied to clipboard

Published 20 hours ago • verified publisher icon rogerc

fix: write after rotateStream destroyed

Open SunshowerC opened this issue 5 years ago • 2 comments

should not write when rotateStream has been destroyed. It would fix this bug: https://github.com/winstonjs/winston-daily-rotate-file/issues/226

SunshowerC avatar Jul 30 '20 04:07 SunshowerC

@rogerc Could you PTAL?

privateOmega avatar Jun 06 '21 13:06 privateOmega

@SunshowerC thanks for the PR, however this seems to be an issue with process specific logging rather than routing all logging through the parent process. Just silencing the error is not really a good fix. Silencing the error discarding the data that should be logged and not deal with the root cause is not what users would expect.

rogerc avatar Jan 21 '22 12:01 rogerc