v8go
v8go copied to clipboard
Add object get property names
Related to https://github.com/rogchap/v8go/issues/213
I'm trying to give a try to my first PR that adds new logic both in Go and in C++.
I'm not 100% sure that want I'm doing is the right thing to do and I would love some guidance if possible. @dylanahsmith @rogchap
Basically, I'm trying to return an array with all the property names from V8 using the obj->GetPropertyNames(local_ctx)
.
Is there anything that I'm missing?
Thanks 😄
Codecov Report
Merging #260 (fab0a50) into master (5e91d3d) will decrease coverage by
0.25%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 95.86% 95.60% -0.26%
==========================================
Files 17 17
Lines 580 592 +12
==========================================
+ Hits 556 566 +10
- Misses 15 16 +1
- Partials 9 10 +1
Impacted Files | Coverage Δ | |
---|---|---|
context.go | 97.14% <80.00%> (-2.86%) |
:arrow_down: |
object.go | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5e91d3d...fab0a50. Read the comment docs.