proxychains-ng icon indicating copy to clipboard operation
proxychains-ng copied to clipboard

Remove wrong _comp_priv_prefix

Open Freed-Wu opened this issue 2 years ago • 2 comments

when i merged the zsh completion i assumed this is a one-off favor, but this is now the 3rd edit. i don't want to clutter the git commit history with zsh completion changes and spend more time with it, so you get one last chance to get this right, else i will remove it again. so take your time to make this the ultimate and final fix.

rofl0r avatar Sep 19 '22 11:09 rofl0r

OK, wait for enough long time to ensure nothing wrong happen. (BTW, even if this change isn't merged, it will not affect anyone. This change does not fix a bug, just remove some unused code, so we can have enough time.)

And this script is not generated automatically (go/rust/python have libraries to generate shell completion script automatically), so if new option is added or old option has changed, the script should be changed manually, which is troublesome. It is the biggest weakness. Maybe something like https://github.com/mirror/x264/blob/master/autocomplete.c is a better method.

Freed-Wu avatar Sep 19 '22 12:09 Freed-Wu

is this good to merge now ?

rofl0r avatar Apr 05 '23 17:04 rofl0r

  • I change the file path to completions/zsh/_proxychains, which should be less confused.
  • Now it should be the final work.

Freed-Wu avatar Apr 06 '23 19:04 Freed-Wu

@rofl0r

Freed-Wu avatar Apr 26 '23 12:04 Freed-Wu