docker-speedtest-analyser icon indicating copy to clipboard operation
docker-speedtest-analyser copied to clipboard

Published 20 hours ago • verified publisher icon roest01

Update evaluation.js

Open cosyd opened this issue 3 years ago • 2 comments

Changed line 93 row.data[0] to row.data as per https://github.com/roest01/docker-speedtest-analyser/issues/75 Credit to https://github.com/Developer22974

cosyd avatar May 14 '21 20:05 cosyd

Interesting. If you revert https://github.com/roest01/docker-speedtest-analyser/commit/1d6455a227ec7700278f2f487d976549fdd725c5, do you still need this change?

I tried changing to row.data without success, but reverting the package updates fixed it. I think the package updates were incomplete - missing the corresponding yarn.lock changes - so they don't really pull down the right packages.

I'm interested to know if you get the same results or not...

owenleonard avatar May 15 '21 13:05 owenleonard

Yupp, this [0] removal is needed to run it properly. @owenleonard : If you just change the file, but not tell the browser to forcefully download the js again (like ctrl+f5), it will use the cached version.

Victoare avatar Jun 25 '21 16:06 Victoare