numerals
numerals copied to clipboard
Bump to version 0.4.2
Not sure if I did the right things so feedback very welcome!
What
A few changes:
- Bumped the version in numerals.cabal
- added entry in changelog
- added dist-newstyle to .gitignore as I was using
cabal v2-build
- fixed test build failures: it was complaining about
(*)
not being in scope, eg:
src-test/Text/Numeral/Language/LIT/TestData.hs:228:12: error: [GHC-88464]
Variable not in scope: (*) :: t96 -> t97 -> i
Suggested fix:
Perhaps you want to add ‘*’ to the import list in the import of
‘Prelude’ (src-test/Text/Numeral/Language/LIT/TestData.hs:19:1-39).
|
228 | , (9 * dec 12, "devyni trilijonai")
Why
Mainly because the current version that's on hackage has fixed upper bounds. This also closes #29
Testing
Tested locally note that some tests fail, including English ones:
$ cabal v2-build --enable-tests
./dist-newstyle/..../test-numerals
...
ENG:
GB:
unique data:
cardinal:
ordinal:
cardinal:
default:
101: [Failed]
Expected 101 = "one hundred and one" but got "one hundred one"
110: [Failed]
Expected 110 = "one hundred and ten" but got "one hundred ten"
111: [Failed]
Expected 111 = "one hundred and eleven" but got "one hundred eleven"
....
Properties Test Cases Total
Passed 3 8099 8102
Failed 0 332 332
Total 3 8431 8434
Benchmarking
$ cabal v2-bench
...
Running 1 benchmarks...
Benchmark bench-numerals: RUNNING...
benchmarking NLD
time 93.50 μs (93.19 μs .. 93.79 μs)
1.000 R² (1.000 R² .. 1.000 R²)
mean 93.49 μs (93.28 μs .. 93.77 μs)
std dev 821.4 ns (639.2 ns .. 1.112 μs)
Packaging
Ran cabal v2-sdist
locally which produced:
$ cabal v2-sdist
Wrote tarball sdist to
..../numerals/dist-newstyle/sdist/numerals-0.4.2.tar.gz
I'm happy to upload it here but I think if you can, as maintainer it would be way, way better for you to do it 😄