ninjabot
ninjabot copied to clipboard
rodrigo-brito
add method `WsCombinedKlineServe` to Binance Future
Codecov Report
Patch coverage has no change and project coverage change: -0.38 :warning:
Comparison is base (
9f24c58) 40.44% compared to head (67dcd8a) 40.06%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 40.44% 40.06% -0.38%
==========================================
Files 19 19
Lines 2893 2920 +27
==========================================
Hits 1170 1170
- Misses 1647 1674 +27
Partials 76 76
| Impacted Files | Coverage Δ | |
|---|---|---|
| exchange/binance.go | 2.19% <0.00%> (-0.01%) |
:arrow_down: |
| exchange/binance_future.go | 0.00% <0.00%> (ø) |
|
| exchange/csvfeed.go | 64.25% <0.00%> (-0.59%) |
:arrow_down: |
| exchange/exchange.go | 0.00% <ø> (ø) |
|
| exchange/paperwallet.go | 68.72% <0.00%> (-0.27%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I would like to understand what is the benefit of including this new signature in the exchange interface.
Do you have idea how we can do it without including new function into interface?
Do you have idea how we can do it without including new function into interface?
If your idea is just to optimize the CandlesSubscription method to reduce the number of open websockets. We can just override the subscription logic to always use this approach. I see no point in keeping both.
Are you consuming the Exchange object outside of a strategy?
