viewport-units-buggyfill icon indicating copy to clipboard operation
viewport-units-buggyfill copied to clipboard

Published 20 hours ago • verified publisher icon rodneyrehm

fixed viewportUnitExpression is matching base64 strings

Open OleksiiKukuruza opened this issue 7 years ago • 2 comments

OleksiiKukuruza avatar Sep 25 '17 08:09 OleksiiKukuruza

@rodneyrehm check now please

OleksiiKukuruza avatar Sep 25 '17 09:09 OleksiiKukuruza

better. But Line 294 uses viewportUnitExpression without the url test - meaning currently only values in KeyFrames are "safe".

The current solution will fail in situations like background: url(…) 2vw 2vh. Since url() can't be nested, we could probably test if a ) comes between url( and the identified value. If this is done, line 359 would need to be touched as well.

rodneyrehm avatar Sep 25 '17 10:09 rodneyrehm