puppet-logrotate icon indicating copy to clipboard operation
puppet-logrotate copied to clipboard

Published 20 hours ago • verified publisher icon rodjek

Make logrotate.conf into a template with defined type

Open apowers opened this issue 11 years ago • 4 comments

It is useful to be able to set defaults for all logrotate logs, especially for those that may be vendor installed and not specifically managed by puppet. This update converts logrotate.conf from a static file to a template using a defined type very similar to the one used for rules.

apowers avatar Jul 08 '13 16:07 apowers

+1

blkperl avatar Mar 24 '14 18:03 blkperl

If i'm reading this right, it would not touch the logrotate.conf if you don't specify to edit it correct? that would be awesome.

Documented my thoughts in #33

gregswift avatar Apr 03 '14 20:04 gregswift

+1 Are there any reasons why this feature has not been merged?

phibos avatar Oct 10 '14 09:10 phibos

I guess since this PR is a total mess. There were 2 commits added which having nothing to do with the actual PR. I've cleaned it up myself (https://github.com/baurmatt/puppet-logrotate/tree/fix_pr15) but want to do some refactoring before creating a new PR. My idea was, to have one template which can be used for /etc/logrotate.conf and /etc/logrotate.d/* since those files are exactly the same beside the additional "<%= rpath %> {" and "}" lines. @rodjek some thoughts about this?

baurmatt avatar Oct 10 '14 10:10 baurmatt