vision-camera-code-scanner icon indicating copy to clipboard operation
vision-camera-code-scanner copied to clipboard
verified publisher icon rodgomesc

fix: use global sdkVersion

Open fdrault opened this issue 3 years ago • 3 comments

Hello ! With react-native 0.70, many users will met build problems with mismatch versions between their project (31) and this library (30).

With this PR, gradle build the library with global compileSdkVersion minSdkVersion and targetSdkVersion versions, defined in your project android/build.graddle. This way, this library versions evolve with the react-native ones

This should fix #92 #90 #100

fdrault avatar Sep 27 '22 12:09 fdrault

Fixed in: https://github.com/jorgebrunetto/vision-camera-code-scanner

jorgebrunetto avatar Sep 28 '22 13:09 jorgebrunetto

i don't think this is fixed in the latest release. i had to explicitly define VisionCameraCodeScanner_compileSdkVersion=31 instead of it using the compileSdkVersion for it to work.

calderaro avatar Sep 30 '22 17:09 calderaro

Can confirm this issue hasn't been fixed in the latest release. I've had to add the suggested work around in order for the app to build for Android.

Wahsner avatar Jan 16 '23 13:01 Wahsner