Bugfix/issue #69 short write

[cseeger-epages]

@rodcorsi here is the PR for issue-69/short-write.

It seems even when i try to use the base: release-4.1 the changes from https://github.com/rodcorsi/mattermail/pull/67 will not be recognized. Any ideas

[cseeger-epages]

maybe the changes are not recognized since i did not synced my branch with release-4.1

[rodcorsi]

Thanks I'll make some tests 👍

[cseeger-epages]

@rodcorsi any updates here ?

[rodcorsi]

Hi @cseeger-epages ! I squash and merge the PR #67 and I think you forgot to update your repo. You need to run the commands to fix your branch:

git fetch remote
git rebase -i remote/release-4.1

On the editor you'll need to delete the existing commits and keep the new ones

drop 39c4fea added filter for redirecting specific folders
drop 865084f fixed missing folder usage
drop 4f5ef19 fixed tests
drop e791343 fixed lint errors
drop 8ad89f5 fixed gofmt lint error
drop 16089a3 changed references to my repo
drop 7b87142 check filter existance before using
drop 810c430 added filter tests
drop 182be4e fixed multiple mailbox select on multiple filter occurence
drop c8cd891 added support for multiple UIDCacheFiles
drop 406a47e fixed uidcache tests
pick 24ba733 fix for various tcp connection errors
pick b766d77 fixed imports to original repo

it'll ocurs some merge conflicts, solve them and then run:

git rebase --continue

I'm imagining that you're using:

git remote -v
origin  https://github.com/cseeger-epages/mattermail (fetch)
origin  https://github.com/cseeger-epages/mattermail (push)
remote  https://github.com/rodcorsi/mattermail (fetch)
remote  https://github.com/rodcorsi/mattermail (push)

[coveralls]

Coverage decreased (-1.8%) to 55.062% when pulling 2e0f81b9a88f6130ae6663845202fb1c1ae36370 on cseeger-epages:bugfix/issue-69-short-write into cecb8902cb49a2164fb17ed6dea5a05ce6e8e978 on rodcorsi:master.

[cseeger-epages]

Hey @rodcorsi sorry for the long time, i hopefully managed to merge it into the master (formaly release-4.1) branch. Can you take a look and make some tests ?

[rodcorsi]

Hi @cseeger-epages! The issue #69 need to be fixed into the master, but I think first, we need to upgrade the lib emersion/go-imap to get your fix emersion/go-imap#173. Recently I tried to upgrade this lib to the version v1.0.0 beta 1, but I could not make it work because the issue emersion/go-imap#107 and the IDLE don't work on Exchange Server, maybe will be necessary to change the way of the imap provider works and remove the loop.

EDIT: I don't want to put the #67 in the release 4.0, because I don't know how this feature will works after upgrade go-imap lib, I think is better to keep this feature to the release 4.1

[cseeger-epages]

@rodcorsi ok makes total sense for me. Maybe if i have time ill dig a bit into https://github.com/emersion/go-imap/issues/107 :D. If not i just wait until you managed to upgrade the lib or changed the implementation removing the loop. Just drop me a comment here if its done and i'll try to migrate the stuff then.