sportsipy icon indicating copy to clipboard operation
sportsipy copied to clipboard

Add missing NBA table_ids in Player

Open baronet2 opened this issue 3 years ago • 1 comments

Hi @roclark ,

Thanks for this amazing repo!

I noticed that some tables on NBA player pages were not being loaded. I've added in the missing tables, except for two which result in errors and will need a bit more work - these are indicated in the code.

From a quick glance, the following stats were previously not loaded or loaded as 0s and are now fixed: lost_ball_turnovers, offensive_fouls, points_generated_by_assists, passing_turnovers, shooting_fouls, net_plus_minus, and_ones, on_court_plus_minus, shooting_fouls_drawn, center_percentage, point_guard_percentage, power_forward_percentage, shooting_guard_percentage, small_forward_percentage.

Some of the tables I've added won't yet have the data loaded since the appropriate fields aren't yet listed (e.g. playoff information for #425), but that seems to merit a separate Pull Request.

Wasn't sure if there was anything to add to the documentation/test suite based on these changes.

Look forward to hearing your thoughts,

Ethan Baron

baronet2 avatar Apr 21 '21 21:04 baronet2

It seems that the Harden test case HTML is outdated and uses a different id for the play-by-play table to the current page. I've added the old id, hoping that the relevant test cases pass this time.

baronet2 avatar Apr 24 '21 15:04 baronet2