wifi icon indicating copy to clipboard operation
wifi copied to clipboard

Adding sudo args

Open Erf- opened this issue 9 years ago • 4 comments

As you can see I splited my previous pull request. Then this one only implement the adding of 'sudo' args in terminal calls and the related tests. Note there is one failure in the tests i did not succeed to solve yet.

Erf- avatar Jul 27 '15 16:07 Erf-

Please also revert the file mode changes.

yohanboniface avatar Aug 03 '15 10:08 yohanboniface

Hi Rocky. I tried to match what you and Yohan Boniface told me to do. Then can you check my latest version. PS: Can you also delete the other pull requests I did. Sorry I am not used to deal with the Travis tool so I did such a mess...

Erf- avatar Aug 03 '15 17:08 Erf-

Ok, I had just a few comments. After those are resolved let's merge this baby. Thanks for all the hard work @Erf- and thanks for the extra review help @yohanboniface.

rockymeza avatar Aug 04 '15 02:08 rockymeza

I made the review in a commit amend to avoid polluting the pull request.

Erf- avatar Aug 04 '15 08:08 Erf-