wifi icon indicating copy to clipboard operation
wifi copied to clipboard

Published 20 hours ago • verified publisher icon rockymeza

Sudo args

Open Erf- opened this issue 9 years ago • 2 comments

Hi Rockymeza. I added some 'sudo' args and the tests related to your connection and scannig methods. Then, I also impleted some tests on their calls. I implemented some dummydata to group all test variables and I modified their calls in test codes.

Erf- avatar Jul 24 '15 15:07 Erf-

Hi @Erf-,

First of all thank you for this work, I appreciate it. I think that adding a sudo argument is important (see #66), but at the same time, there are too many changes in this pull request some of which I agree with and some of which I don't agree with.

It would be great if we could separate this pull request into two:

  1. add sudo argument
  2. refactor the tests

And we could disect/discuss them separately.

What do you think?

rockymeza avatar Jul 27 '15 01:07 rockymeza

Ok I saw your comments and I am trying to match with them.

Erf- avatar Jul 27 '15 13:07 Erf-