OpenTracker icon indicating copy to clipboard operation
OpenTracker copied to clipboard

question about sample_update.cc

Open jianingwangind opened this issue 5 years ago • 1 comments

in function update_sample_space_model in case "if memory is full", I got confused about the prior weights renormalization step. why the loop is controlled by i < prior_weights_[i] instead of i < prior_weights_.size(). I cant see the meaning of the former one. I am looking forward to your reply:)

jianingwangind avatar Mar 13 '19 10:03 jianingwangind

also there is a step to ensure that the sample with higher prior weight is assigned id1. I think here you need prior_weights_[closest_exist_sample_pair.y] >prior_weights_[closest_exist_sample_pair.x] instead of prior_weights_[closest_exist_sample_pair.x] >prior_weights_[closest_exist_sample_pair.y]

jianingwangind avatar Mar 13 '19 12:03 jianingwangind