smartnode icon indicating copy to clipboard operation
smartnode copied to clipboard

V2 auto init vp

Open thomaspanf opened this issue 1 year ago • 4 comments

Implements #626 in V2

thomaspanf avatar Aug 28 '24 22:08 thomaspanf

we can bump the rocketpool-go version now. Note the tx-refactor branch is being used for V2.

0xfornax avatar Sep 03 '24 15:09 0xfornax

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ :robot:
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/common/rewards 1.21% (ø)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/node 0.20% (-0.01%) :thumbsdown:
github.com/rocket-pool/smartnode/v2/shared/config 5.95% (ø)
github.com/rocket-pool/smartnode/v2/shared/config/ids 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed :robot:
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/common/rewards/utils.go 2.92% (ø) 1781 52 1729
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/node/auto-init-voting-power.go 0.00% (ø) 356 (+356) 0 356 (+356)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/node/node.go 1.16% (-0.06%) 1381 (+64) 16 1365 (+64) :thumbsdown:
github.com/rocket-pool/smartnode/v2/shared/config/ids/ids.go 0.00% (ø) 0 0 0
github.com/rocket-pool/smartnode/v2/shared/config/smartnode-config.go 3.59% (ø) 1253 45 1208

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

github-actions[bot] avatar Oct 11 '24 17:10 github-actions[bot]