smartnode icon indicating copy to clipboard operation
smartnode copied to clipboard

Published 20 hours ago • verified publisher icon rocket-pool

feat: Migrate networks to yml file (1 of 2)

Open activescott opened this issue 3 months ago • 3 comments

Submission for milestone B of bounty BA0902402 to move networks to yaml.

The networks-default.yml file is in rocket-pool/smartnode-install#122

fixes #438

@jshufro Can you please review and make sure this is on the right track. I think this is complete. The things that are on my mind though:

  • Not super clear what would be an effective set of tests as much of that data is used in operations that I'm not sure how to easily/quickly exercise. If you want to suggest some test cases I'm happy to run them. I was able to use rocketpool service config and restart my holesky node and it seems fine.
  • Am I missing some other places where network info is needed?

activescott avatar Mar 11 '24 21:03 activescott