Tim Rühsen
Tim Rühsen
Thanks for testing @eli-schwartz > With Msys2 + clang, it fails due to GetACP being undefined. That has been my fear. GetACP() requires Windows.h (see https://learn.microsoft.com/en-us/windows/win32/api/winnls/nf-winnls-getacp). > "unresolved external symbol...
Thank you @vszakats ! @eli-schwartz Pushed the removal of WSA code. When #231 is merged, I'll rebase this PR and ping you for another round of tests.
@vszakats or someone else, could you test again building libpsl on Windows / Msys2 and running the tests? If tests fail, it would be interesting to see the log output...
@eli-schwartz Just to make sure, without the new `is_ip` functions, does the test succeed? Because if the first parameter to `psl_is_cookie_domain_acceptable()` is an IP address, the function returns 0. Getting...
The reason for the fuzz tests not building is likely a missing DLL (need to be added to LDADD in fuzz/Makefile.am), but can't test that anyway. With MinGW on Linux,...
@NahuFigueroa97 If you didn't succeed with meson, feel free to reopen.
Libidn2 either has the needed unistring functions included (at least this is a built option for libidn2) or is already linked to libunistring when dynamically built. E.g. ``` $ ldd...
> configure: error: You requested libidn2|libidn but libunistring is not installed. @TurtleWilly Can you test #243?
This issue has been fixed in git master.
Can you provide `config.log`? What is the output of `locale`? What ICU version are you using? What compiler/version are you using? Does the same happen with libidn2?