mpp icon indicating copy to clipboard operation
mpp copied to clipboard

It is required to bump the version

Open xaionaro opened this issue 10 months ago • 3 comments

It looks like file https://github.com/rockchip-linux/mpp/blob/ee946af015c350c926a0fca2f02da8e429f8b079/pkgconfig/rockchip_mpp.pc.cmake#L9 last time was updated 4 years ago. Meanwhile it seems like a lot of things changed in the library. For example, apparently usage of the old version of the lib causes this variant of ffmpeg to segfault: https://github.com/nyanmisaka/ffmpeg-rockchip/issues/56#issue-2224137907

So to avoid these segfaults one would need to check if the library is fresh enough, which requires the version of the lib itself be periodically bumped.

Also it looks like the latest release was long time ago, which might make various distributions to use severely outdated version of the lib.

xaionaro avatar Apr 04 '24 14:04 xaionaro

agreed. it can solve that segfault. ping @HermanChen

great9 avatar Apr 05 '24 11:04 great9

Use new version tag 1.0.x or update a larger number than 1.3.8?

HermanChen avatar Apr 07 '24 05:04 HermanChen

Use new version tag 1.0.x or update a larger number than 1.3.8?

update to a larger number that makes sense with the rest of the mpp

great9 avatar Apr 07 '24 07:04 great9

1.0.5 tag has update the number to 1.3.9

HermanChen avatar Apr 22 '24 08:04 HermanChen

Thanks!

xaionaro avatar Apr 22 '24 11:04 xaionaro

P.S.: Does it makes sense to make an official release so that distribution maintainers will see they need to update the version of the package? https://github.com/rockchip-linux/mpp/releases

xaionaro avatar Apr 22 '24 13:04 xaionaro

P.S.: Does it makes sense to make an official release so that distribution maintainers will see they need to update the version of the package? https://github.com/rockchip-linux/mpp/releases

Done

HermanChen avatar Apr 23 '24 01:04 HermanChen

Thanks!

xaionaro avatar Apr 23 '24 10:04 xaionaro