vektor icon indicating copy to clipboard operation
vektor copied to clipboard

Improve vector by uniformizing the interface

Open dvberkel opened this issue 11 years ago • 3 comments

addresses issue #11

dvberkel avatar Aug 02 '13 10:08 dvberkel

This pull request treats 2D vectors as 3D vectors with a z-component of 0.

Depending on the client this could break backwards compatibility.

dvberkel avatar Aug 02 '13 10:08 dvberkel

@rockbot Do not forget that this pull request is a suggestion, and that an possible response is: "I do not like it, for these reasons".

dvberkel avatar Aug 04 '13 07:08 dvberkel

@rockbot I was wondering if you would like to see a different implementation or that you are ok with the one provided in this pull-request?

A different implementation would for example treat 2D vectors as vectors with 2 components and have a 'lift' method to lift them into a 3D vector.

What would you prefer?

dvberkel avatar Aug 09 '13 20:08 dvberkel