repliear icon indicating copy to clipboard operation
repliear copied to clipboard

[materialite] Adds materialite to the main issue list [1/n]

Open tantaman opened this issue 1 year ago • 1 comments

In follow up PRs:

  • incrementally maintain the kanban board
  • fetch a page at a time rather than all issues at once
  • emit normal js collections
  • syncing comments slows down quite a bit with the new findCreates method in cvr.ts. Maybe I can make this better 🤔

Diff duration:

https://github.com/rocicorp/repliear/assets/1009003/43e47890-6fd7-48a9-983d-c68c2b560070

I almost don't believe the numbers (< 1ms diffs) but they match the notebook which uses a dataset of 1 million items: https://observablehq.com/@tantaman/materialite#benchmarking-with-materialite

Filter updates:

https://github.com/rocicorp/repliear/assets/1009003/8c9f90e4-c1ec-4433-b380-48989b92275f

tantaman avatar Dec 15 '23 17:12 tantaman

There's a flash of stale state then current state when swapping between Kanban and List views 🤔. Need to figure this out.

Probably something in the hook implementation: https://github.com/vlcn-io/materialite/blob/7702cdece6f5d37b294189a2a38517d70005265e/packages/react/src/hooks.ts#L80

Update: the stale state flash came from: https://github.com/rocicorp/repliear/pull/160/commits/d7102f1f42db82c3c2621844ebd55c4f6ec3aff5

tantaman avatar Dec 15 '23 22:12 tantaman