talkshow
talkshow copied to clipboard
Changed slugify from talkshow/utils.py to ext/slugification.py
Close #32
Hello @Riverfount! Thanks for submitting the PR.
-
There are no PEP8 issues in the file
talkshow/blueprints/restapi/resource.py
! -
There are no PEP8 issues in the file
talkshow/ext/cli.py
! -
There are no PEP8 issues in the file
tests/test_api.py
!
Codecov Report
Merging #33 into extended will increase coverage by
0.49%
. The diff coverage is100%
.
@@ Coverage Diff @@
## extended #33 +/- ##
============================================
+ Coverage 84.57% 85.07% +0.49%
============================================
Files 17 17
Lines 201 201
============================================
+ Hits 170 171 +1
+ Misses 31 30 -1
Impacted Files | Coverage Δ | |
---|---|---|
talkshow/ext/slugification.py | 100% <ø> (ø) |
|
talkshow/blueprints/restapi/resource.py | 100% <100%> (ø) |
:arrow_up: |
talkshow/ext/cli.py | 68.75% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8550a3c...7265f26. Read the comment docs.
Hello @Riverfount! Thanks for submitting the PR.
* There are no PEP8 issues in the file [`talkshow/blueprints/restapi/resource.py`](https://github.com/Riverfount/talkshow/blob/7265f26eb57df2b5653a1a1b440fa895f31798a8/talkshow/blueprints/restapi/resource.py) ! * There are no PEP8 issues in the file [`talkshow/ext/cli.py`](https://github.com/Riverfount/talkshow/blob/7265f26eb57df2b5653a1a1b440fa895f31798a8/talkshow/ext/cli.py) ! * There are no PEP8 issues in the file [`tests/test_api.py`](https://github.com/Riverfount/talkshow/blob/7265f26eb57df2b5653a1a1b440fa895f31798a8/tests/test_api.py) !
I revised the codes of these files and I don't find PEP8 errors in them!!!
@rochacbruno caso vc aceite eu posso ser o mantenedor aqui... sei que essa é tranquilinha, mas será para meu crescimento em projetos open source e em Flask! ;-)