Rocco Musolino comments

Results 220 comments of


                                            Rocco Musolino

crypto: Provide OWASP session management security recommendations

I don't know if it's worth introducing this complexity to the code. And if this is wanted at all. The sessions are stored in-memory. Inside the process. If someone manage...

Class constructor LRUCache cannot be invoked without 'new'

did you `yarn install` or `npm install`? what version of `lru-cache` did npm bring in when you installed?

Class constructor LRUCache cannot be invoked without 'new'

if you use the yarn install command the version installed should be `4.1.5` as stated in `yarn.lock`. So I don't know how you possibly fetched 6.0.0.

MemoryStore doesn't save ES2015/ES6 Map objects correctly

I wasn't able to reproduce this issue. I'm using express `4.16.3` and node `v8.11.1`. PS. also note that the Map obj are not json serializable, and by default memorystore uses...

MemoryStore doesn't save ES2015/ES6 Map objects correctly

You're right. Do you mind open a PR? thanks

Provide a CDN

I'm recommending it to cdnjs as first choice: [cdnjs/10668](https://github.com/cdnjs/cdnjs/issues/10668)

Using express vhost behind a reverse proxy

Thanks +1

Progress bar won't render when redirecting output to a file

Probably because this module works only with a writable stream in a text terminal (`tty`) context. Check [lib/node-progress.js#L126](https://github.com/visionmedia/node-progress/blob/master/lib/node-progress.js#L126) ```javascript if (!this.stream.isTTY) return; ```

won't set Content-Type header when body is not preset

I Agree, this cause errors on some strictly configured web servers.