roc-toolkit icon indicating copy to clipboard operation
roc-toolkit copied to clipboard

Unit tests for parser & composer status codes

Open gavv opened this issue 11 months ago • 5 comments

This is a follow-up for #766 and #737.

Add simple tests to check how status codes returned from implementations of IParser and IComposer:

  • [ ] Add unit tests for rtp::Parser, rtp::Composer, fec::Parser, fec::Composer for the cases when they return non-OK status.

  • [ ] Add unit tests for components that use parsers and composers. In tests, check that the component properly forwards error code from parser/composer to the caller.

    For example, a test makes Composer to fail with StatusNoMem, and check Shipper::write() returns StatusNoMem.

    Classes to cover:

    • [ ] fec::BlockReader
    • [ ] fec::BlockWriter
    • [ ] packet::Shipper
    • [ ] audio::Packetizer
    • [ ] audio::Depacketizer

gavv avatar Jan 16 '25 12:01 gavv

Hey! I'd like to work on this issue.

singsian avatar Jan 28 '25 20:01 singsian

Hey, I'd love to take a look at this as well!

OdenDillenkoffer avatar Jan 28 '25 20:01 OdenDillenkoffer

Hi, thanks, I guess @singsian could take it, as he/she commented first. @OdenDillenkoffer Feel free to take a look at other help-wanted issues, there is plenty of them :)

gavv avatar Feb 05 '25 05:02 gavv

Hi!! I would like to try my hand at this if possible

apithikkat avatar Jun 02 '25 16:06 apithikkat

@apithikkat Thank you, you're welcome!

gavv avatar Jun 04 '25 10:06 gavv