roc-toolkit icon indicating copy to clipboard operation
roc-toolkit copied to clipboard

Added rpm spec for building a rpm package

Open mk0x9 opened this issue 4 years ago • 3 comments
trafficstars

Hi, I had added rpm spec file to build rpm packages based on the master branch on the copr.

As fedora switched to pipewire already I plan at a later stage push to the copr pipewire built with roc modules (right now fedora doesn't ship them).

mk0x9 avatar Oct 11 '21 19:10 mk0x9

This is great, thanks! I think we should add it to our CI too - just a check that verifies that the package is built successfully. Do you have any hints or suggestions on this?

gavv avatar Oct 25 '21 16:10 gavv

Sure, I'll try to think of the best way to achieve the result, I had never used fedora copr before. I plan also to add script to build an rpm package with roc modules for the pipewire. Although I'm not sure if this repo would be the best place to host it.

mk0x9 avatar Oct 30 '21 16:10 mk0x9

Hi!

  • Is this PR still relevant?
  • The URL in README gives 404: https://copr.fedorainfracloud.org/coprs/mk9/roc-toolkit-dev/package/roc-toolkit/
  • The spec defines name as libroc, but it also provides command-line tools, not just the library?
  • Is it possible to get version from git tag or .h header instead of hard-coding it? So that I don't need to update it every release.

gavv avatar Jun 26 '22 11:06 gavv

I've added an RPM spec to the repo, based on #475, #462 (this PR), and the spec from Fedora. See d3ac0d075644b40fa61c67954a611c17dc2da8c4

Let me know if any changes are needed.

Thanks!

gavv avatar Mar 09 '23 09:03 gavv

Follow-up issue: https://github.com/roc-streaming/roc-toolkit/issues/526

gavv avatar Mar 09 '23 12:03 gavv