roc-droid icon indicating copy to clipboard operation
roc-droid copied to clipboard

Publish on f-droid

Open SonaliBendre opened this issue 2 years ago • 8 comments

add on f-droid

SonaliBendre avatar May 23 '22 15:05 SonaliBendre

Good idea

gavv avatar Nov 29 '22 10:11 gavv

This strongly requires having versionCode and versionName fixed (which also is why auto-updates in my repo don't work currently). Especially the former is crucial, as that's what Android uses internally to tell versions apart – and what F-Droid uses to see if there are new releases available. To both it currently looks like there was only a single release ever…

@ortex could you please take care for that? Also while on it, it would be great if versionName would reflect the tag name, i.e. currently would show 0.0.3 instead of 1.0 :wink: Thanks in advance!

IzzySoft avatar Dec 11 '22 15:12 IzzySoft

See https://github.com/roc-streaming/roc-droid/issues/24#issuecomment-1348490894

gavv avatar Dec 13 '22 12:12 gavv

Concerning my repo, see my reply there – thanks, that should work. As for F-Droid, the bot will tell once it scans the repo after your opening a request for packaging. It usually looks into build.gradle first (and will fail there due to the dynamic codes), but should also take AndroidManifest.xml into consideration when it failed at the gradle. So may I encourage you to go for the RFP then? And until that's finally processed, maybe pick a badge to link to your app in my repo?

would fit nicely next to your build badge :wink:

IzzySoft avatar Dec 13 '22 13:12 IzzySoft

So may I encourage you to go for the RFP then? And until that's finally processed, maybe pick a badge to link to your app in my repo?

Sure.

The version on IzzyOnDroid is still 1.0 instead of 0.0.4. What should we do with this?

[![IzzyOnDroid](https://img.shields.io/endpoint?url=https://apt.izzysoft.de/fdroid/api/v1/shield/org.rocstreaming.rocdroid)](https://apt.izzysoft.de/fdroid/index/apk/org.rocstreaming.rocdroid)

IzzyOnDroid

gavv avatar Dec 14 '22 09:12 gavv

So may I encourage you to go for the RFP then? And until that's finally processed, maybe pick a badge to link to your app in my repo?

https://github.com/roc-streaming/roc-droid/pull/38

gavv avatar Dec 14 '22 10:12 gavv

The version on IzzyOnDroid is still 1.0 instead of 0.0.4. What should we do with this?

Wait for the sync :smiley: See what the repo shows as last version online:

Version 1.0 (2021-11-18)

I've just updated it manually in the "staging area" (as the auto-updater would not have fetched it this time, see above), sync happens daily around 7 pm UTC (winter time; 6 pm UTC in summer time). This is how it looks in staging currently, which will be what the online site will show after the sync:

Version 0.0.4 (2022-12-14)

And thanks for adding the badge! :heart_eyes:

IzzySoft avatar Dec 14 '22 12:12 IzzySoft

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14910

JamesOsborn-SE avatar Apr 23 '24 00:04 JamesOsborn-SE

Seeing the app is now available at F-Droid.org, and the Readme carrying both badges now: I assume you want to keep it available at IzzyOnDroid then? Just asking to make sure it wasn't just an oversight.

IzzySoft avatar May 27 '24 10:05 IzzySoft

@IzzySoft I'm not familiar with IzzyOnDroid and its user base (and TBH F-Droid too), but IMHO if it gives any benefits to users, then why not to keep it. Unless it's a burden for you of course.

gavv avatar May 28 '24 11:05 gavv

No problem here as long as the APK does not grow too much :wink: Marked the app for "keep" then, linking here for reference. Thanks!

IzzySoft avatar May 28 '24 14:05 IzzySoft

Btw, while I'm here:

! repo/org.rocstreaming.rocdroid_2002.apk declares sensitive permission(s): android.permission.RECORD_AUDIO
! repo/org.rocstreaming.rocdroid_2002.apk contains signature block blobs: 0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

The permission is clear (needed by the receiver), so I just added it to the app's "green list" (giving this explanation). As for DEPENDENCY_INFO_BLOCK, this can easily be avoided with a tiny modification to your build.gradle:

android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs.
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles.
        includeInBundle = false
    }
}

For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains. More details can be found e.g. here: Ramping up security: additional APK checks are in place with the IzzyOnDroid repo.

Thanks in advance!

IzzySoft avatar Jun 16 '24 12:06 IzzySoft