roc icon indicating copy to clipboard operation
roc copied to clipboard

Reporting certain pattern parse errors

Open rtfeldman opened this issue 4 years ago • 1 comments

Putting this into the repl:

» 0,0

...yields this panic:

'not yet implemented: unhandled parse error: Pattern(IndentEnd(3, 7), 3, 6)', compiler/reporting/src/error/parse.rs:534:14

Similarly, this:

» 0,

...yields a similar panic for a different Pattern variant:

'not yet implemented: unhandled parse error: Pattern(Start(3, 6), 3, 6)', compiler/reporting/src/error/parse.rs:534:14

rtfeldman avatar May 27 '21 22:05 rtfeldman

Update: 0,0 now results (in the online REPL) in:

» 0,0

── UNEXPECTED COMMA ────────────────────────────────────────────────────────────

I am trying to parse an expression, but I got stuck here:

1│  app "app" provides [replOutput] to "./platform"
2│
3│  replOutput =
4│      0,0
         ^

This comma in an invalid position.

which looks ok. However, 0, still yields a panic.

kukimik avatar May 06 '24 13:05 kukimik

I got a an error message instead of a panic with 0, now, still needs improvement though.

» 0,

── UNHANDLED PARSE ERROR ───────────────────────────────────────────────────────

I got stuck while parsing this:

1│  app "app" provides [replOutput] to "./platform"
2│
3│  replOutput =
4│      0,
          ^

Here's the internal parse problem:

    Pattern(Start(@68), @68)

Unfortunately, I'm not able to provide a more insightful error message
for this syntax problem yet. This is considered a bug in the compiler.

Note: If you'd like to contribute to Roc, this would be a good first issue!

skyqrose avatar Nov 11 '24 14:11 skyqrose