rbt icon indicating copy to clipboard operation
rbt copied to clipboard

walk the build graph in parallel

Open BrianHicks opened this issue 3 years ago • 5 comments

This makes Coordinator walk the build graph in parallel.

After some discussion on Zulip, I did this with async Rust instead of spawning threads directly. I think this could still use some improvement, but it works well for now. We can tune it with tokio-console or something soon!

BrianHicks avatar Oct 21 '22 16:10 BrianHicks

@roc-lang/rbt-reviewers I'm requesting review of this since it seems like a configuration failure in CI. The tests all work locally, and the lints all pass in CI. 👍

BrianHicks avatar Oct 21 '22 16:10 BrianHicks

You should be able to use roc gen-stub-lib some-example-app.roc on nightly now to work around the build issues here.

Just run it before cargo test

bhansconnect avatar Oct 27 '22 21:10 bhansconnect

amazing, thank you!

BrianHicks avatar Nov 01 '22 21:11 BrianHicks

@bhansconnect any idea what could be going on here? Looks like we're generating libapp.so correctly, but then cargo test complains it can't be found. Is it looking somewhere other than in the current directory, do you think? https://github.com/roc-lang/rbt/actions/runs/3374554604/jobs/5600303279

BrianHicks avatar Nov 02 '22 03:11 BrianHicks

ok, monkeyed around with LD_LIBRARY_PATH. Now it's saying this:

/home/runner/work/rbt/rbt/target/release/deps/host-e02e8b3c7e864cef: error while loading shared libraries: ./libapp.so: ELF file's phentsize not the expected size

BrianHicks avatar Nov 02 '22 16:11 BrianHicks