node-pixrem
node-pixrem copied to clipboard
Fallbacks added everywhere even on IE >= 10
I am seeing px fallbacks added for every rem rule (not just those in pseudo-selectors or font shorthands) when my browserslist is set to "Explorer >= 10".
I believe the intended behaviour is that this should only happen for IE <= 8 ?
We have a test for that and it works as you expect https://github.com/robwierzbowski/node-pixrem/blob/master/test/test.js#L247-L252
So, your problem might be elsewhere ?
Maybe your problem is related to #38 ?
Maybe meanwhile, cssnext should pass the option (I know @chucksellick use it).
@MoOx : It could be great indeed.
@MoOx @iamvdo this is also being an issue for me. I'm currently using pixrem
through cssnext
and it seems to bypass the rules I specify on the JSON configuration file.
Ok we added something in cssnext, but it appears to be unnecessary (if I keep the added test, but remove the code changed, pixrem still add rem for IE 9 and IE 10 (eg on body for font-size). @iamvdo does this plugin add every rem as px for every rules until IE 11 ?
From what I am seeing here https://github.com/robwierzbowski/node-pixrem/blob/c21d67a4729a8a497c0b9768ddf65c57e4ec2df6/test/test.js#L268-L273 you have specific behavior for IE9.
Ok my bad. PR was incorrectly refering to pixrem as the name of the feature, but it's "rem" in cssnext. So it's now ok in cssnext :)