cronxbmc icon indicating copy to clipboard operation
cronxbmc copied to clipboard

dbuteau

Open dbuteau opened this issue 7 years ago • 2 comments

Made lot of improvement, don't know if you're interested in. Feel free to merge or refuse:

  • AddJob now return the job.id created: (ease later use for addon, they can memorize/keep the id in their config)
  • Anchor the job.id: the id is wrote in the cron.xml now (need by above, the id must not change anymore addons count on it )
  • add updateJob method: addons can now update/replace their own previously created cron
  • on addJob method: check if expression + command is already in job list, if yes does not add the cron. Avoid filling xml with exactly same cron (for example if two differents addon add same command and same expressions, or if an addon add cron each time it's launched without checking if already launched/created). Because i think having 10+ same cron, launching same command in same time is resources-consuming (furthermore xml & ui is uselessly filled)
  • stop using utils.log use xbmc.log in place

Seems to work fine on my kodi

dbuteau avatar Jan 13 '18 15:01 dbuteau

Wow, thanks for all the work. I'll go through all this in detail over the next day or two but based on the descriptions I like the additions here. Thanks!

robweber avatar Jan 13 '18 16:01 robweber

warning don't merge, i just realized i forgot to change UI for job.ID change
It create an exception when editing cron in GUI...

dbuteau avatar Jan 13 '18 19:01 dbuteau