Rob Walch

Results 623 comments of Rob Walch

> A change will be needed to eme-controller in loadKey to return a promise that resolves earlier Here's an example: ```patch diff --git a/src/controller/eme-controller.ts b/src/controller/eme-controller.ts index dfa30d249..c76ca89de 100644 --- a/src/controller/eme-controller.ts...

> @robwalch your proposed change works on the TV! 🚀 thank you for the quick response! Hi @grabofus. Great! Would you mind submitting a PR with the change so that...

`SubtitleStreamController` is responsible for loading WebVTT and IMSC1 subtitle segments only with the `SubtitleTrackController` responsible for selection of the media option playlists containing those segments. 608 captions (and all captions...

Hi @zivac. Thank you for the bug report. HLS.js leaves playback and seeking up to the HTMLMediaElement. The HTMLMediaElement controls should be supported provided the underlying HTMLMediaElement API is as...

Please fill out each section of the bug report appropriately. Repeating the same statement does not provide enough information for us to triage you issue.

Closing as incomplete with no response. Please include actionable information when reporting issues.

Please fill out the [Bug Report Template](https://github.com/video-dev/hls.js/issues/new?assignees=&labels=Bug%2CNeeds+Triage&template=bug.yaml) as part of your issue, making sure to include: - Test stream/page (if possible) - Steps to reproduce - Expected behavior - Actual...

> player call a url that is api return 16byte (key)+16byte(random). KEY_LOADING is an event that notifies the application that a key is loading. It does not accept a return...

You can use xhrSetup or a custom loader or perhaps to modify a request or provide a custom response.

`xhrSetup` and [replacing `loader` with a custom loader class](https://codepen.io/robwalch/pen/GRbOpaJ) allow for requests to be intercepted, modified, and delayed. Use a custom loader if you need more context than the URL...