[FEATURE] Add Dark mode #209 #98 #31

[timfrankentwf]

Let me start by saying that this is my very first Pull Request on a larger project, so sorry if I miss some obvious steps.

I enjoy having dark mode for everything and this application should not be left out. This feature is related to #209, #98 and #31. There I already mentioned that I used the dark theme from https://github.com/AngryCarrot789/WPFDarkTheme as I was doing pretty much the same thing.

Things that work:

• [x] Having a Dark Mode.
• [x] A checkbox to switch between Light and Dark mode.
• [x] Remember which mode was selected on the next startup (using the existing Settings class).
• [x] Video player and other dialogs also change mode.
• [x] The switch between light and dark theme is now handled before loading the window, preventing the visual artifact during startup.

[robvdpol]

Cool, I'll review this when I have the time.

[C0Nd3Mnd]

Would it be possible to inherit the dark mode setting from the system (Windows 10 or higher) instead of (or in addition to) having the setting in the app itself?

[Psybertr0n]

@robvdpol Can you merge @timfrankentwf's changes for Dark Mode for a release? It would be greatly appreciated. A setting to choose from Light, Dark and Inherit from System as suggested above would be nice.

[ForthtuN]

Yes, merge would be great, the white is hurting my eyes when watching at night. Dark theme would make this already amazing and nr1 app even better

[timfrankentwf]

I have updated the pull request to fix some small issues.

[Tanguille]

Nice effort! I would love to see darkmode everywhere too :) Is it in the latest release? If not when could we expect it to release?

[ForthtuN]

Seems it has some new conflicts before, its not in the latest version atleast

[timfrankentwf]

The merge conflicts happen because it's behind the main branch, the issues are easy to solve (mostly allowing to add the few additional lines of code). But there's no point in re-syncing and fixing those issues again when new commits are still added to the main branch.

I have no control on if/when this feature will be added.

[T0m0rr0w]

Any progress on this? It's been over half a year and still no dark mode. It does not have to be perfect. Even if some UI elements require further patches atleast the main window would not hurt my eyes. From what i've seen most programs that add dark mode alse require patches down the line to presumably fix small UI issues.

It coule be labeled as beta or testing to let the user know that it is still work in progress.

[robvdpol]

Fixing the live streams (DRM) is top priority at the moment. Dark mode will come after that.