robusta icon indicating copy to clipboard operation
robusta copied to clipboard

Runner: Log target channel name when slack API requests fail

Open mario-steinhoff-gcx opened this issue 2 years ago • 3 comments
trafficstars

Describe the bug

When a slack API requests fails, the affected slackSink name is not logged. This makes troubleshooting hard in situations with more than one slackSink.

To Reproduce Steps to reproduce the behavior:

  1. Configure multiple slack receivers
  2. Do something that make the request fail, e.g. restrict channel posting permissions
  3. View runner log:
2023-02-03 16:48:34.213 ERROR    error sending message to slack
e=The request to the Slack API failed. (url: https://www.slack.com/api/chat.postMessage)
The server responded with: {'ok': False, 'error': 'restricted_action'}
<slack message details>

Expected behavior

For every failed slack API request, the target sink name appears in the log.

mario-steinhoff-gcx avatar Feb 03 '23 17:02 mario-steinhoff-gcx

@mario-steinhoff-gcx would you be interested in contriburing a PR for this? We have instructions on setting up a dev environment here

aantn avatar Feb 22 '24 16:02 aantn

@aantn In theory yes but right now I dont have any capacity for this.

mario-steinhoff-gcx avatar Feb 22 '24 16:02 mario-steinhoff-gcx

Understood, thanks

On Thu, Feb 22, 2024, 18:46 Mario Steinhoff @.***> wrote:

@aantn https://github.com/aantn In theory yes but right now I dont have any capacity for this.

— Reply to this email directly, view it on GitHub https://github.com/robusta-dev/robusta/issues/714#issuecomment-1959848400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYUBZGI6Q7HK6HYOWR3ODYU5Y7BAVCNFSM6AAAAAAUQQKIYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZHA2DQNBQGA . You are receiving this because you were mentioned.Message ID: @.***>

aantn avatar Feb 22 '24 16:02 aantn