robusta icon indicating copy to clipboard operation
robusta copied to clipboard

Trigger: on_kubernetes_resource_X support for crds

Open nice-pink opened this issue 3 years ago • 7 comments

Is your feature request related to a problem? We are using argo-rollouts instead of deployments. To support create/delete/update detection for the Rollouts it would be nice to have an e.g. on_kubernetes_resource_create trigger where the kind and apiVersion could be defined. This way the trigger would not be limited to argo rollouts but to any crds.

Describe the solution you'd like Add triggers:

  • on_kubernetes_resource_create
  • on_kubernetes_resource_delete
  • on_kubernetes_resource_update
  • on_kubernetes_resource_all_changes

Triggers definitions could be:

on_kubernetes_resource_create:
  kind: Rollout
  apiVersion: argoproj.io/v1alpha1

Describe alternatives you've considered Currently I'm using on_kubernetes_any_resource_create which is just to noisy.

nice-pink avatar Oct 06 '22 15:10 nice-pink

Hey, thanks for reporting.

It's a good idea and something we'd like to support.

That said, we don't have a specific ETA yet. We're working on some other stuff first.

If you'd be interested in contributing a PR for this, please let us know and we'll help point you in the right way.

aantn avatar Oct 08 '22 20:10 aantn

Sounds good. Would be happy to work on it when finding the time. Any suggestions appreciated.

nice-pink avatar Oct 08 '22 20:10 nice-pink

Sounds good. Would be happy to work on it when finding the time. Any suggestions appreciated.

nice-pink avatar Oct 09 '22 01:10 nice-pink

Cool, thanks. What's your level of experience with go and/or python?

aantn avatar Oct 09 '22 12:10 aantn

Quite experienced in python. Started with go a while ago.

nice-pink avatar Oct 10 '22 07:10 nice-pink

Any updates on this?

nice-pink avatar Dec 13 '23 08:12 nice-pink

It would further be nice to list argo-rollouts in the apps list.

nice-pink avatar Dec 13 '23 09:12 nice-pink