robusta icon indicating copy to clipboard operation
robusta copied to clipboard

Remove Misconfigured example

Open ejsundstr opened this issue 3 years ago • 4 comments

The way this was written the given example was incorrect, but that is only clarified in the follow up statement about the minimum of 120 seconds. I just choose a random what I hope is valid example. I was just browsing your docs and haven't actually started using robusta.

ejsundstr avatar Jun 10 '22 05:06 ejsundstr

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 10 '22 05:06 CLAassistant

I gotta figure out if I can sign your CLA feel free to close this and fix it yourself.

ejsundstr avatar Jun 10 '22 05:06 ejsundstr

Hi Eric, nice catch!

Regarding the CLA, I hope it doesn't prevent you from contributing! I'm happy to answer any questions about it. We've tried to make it as lightweight as possible. (E.g. you're giving us a license to use your contribution, not reassigning the copyright to us.)

I know no one likes reading legal text, but it's actually fairly short and readable!

aantn avatar Jun 10 '22 08:06 aantn

@aantn I read the whole agreement last night and appreciated the brevity. But I made this change while at work and just need figure out if I'm able to Represent it.

Since the goal of the PR was solve the problem in the docs and not to obtain some form of GH cred, I am still very willing for you to just do this yourself.

ejsundstr avatar Jun 10 '22 17:06 ejsundstr

@ejsundstr any chance you can sign that after all? If not, I'll close this and fix it myself.

aantn avatar Aug 27 '22 22:08 aantn

@ejsundstr closing this PR and will fix separately.

Good work spotting the error. If you're at Kubecon NA please stop by our booth! We'd love to give you some nice swag :)

aantn avatar Sep 12 '22 19:09 aantn