robusta icon indicating copy to clipboard operation
robusta copied to clipboard

Poor alt text on index page

Open jsoref opened this issue 3 years ago • 5 comments

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Turn off loading images in your web browser
  2. Go to https://docs.robusta.dev/master/

Expected behavior Alt text should be meaningful.

If the logo is the logo for Robusta, then the word Robusta should be in the alt text.

Screenshots image

Desktop (please complete the following information):

  • OS: macOS Big Sur
  • Browser Chrome
  • Version 98

Additional context Add any other context about the problem here.

jsoref avatar Feb 20 '22 19:02 jsoref

Thank you for reporting!

On Sun, Feb 20, 2022 at 9:19 PM Josh Soref @.***> wrote:

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Turn off loading images in your web browser
  2. Go to https://docs.robusta.dev/master/

Expected behavior Alt text should be meaningful.

If the logo is the logo for Robusta, then the word Robusta should be in the alt text.

Screenshots [image: image] https://user-images.githubusercontent.com/2119212/154860183-937ada34-3fad-4879-814b-4e1294872382.png

Desktop (please complete the following information):

  • OS: macOS Big Sur
  • Browser Chrome
  • Version 98

Additional context Add any other context about the problem here.

— Reply to this email directly, view it on GitHub https://github.com/robusta-dev/robusta/issues/229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYUBZIKVLPUNYT3JUAF63U4E5CXANCNFSM5O4ZVCGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

aantn avatar Feb 20 '22 19:02 aantn

@aantn Should I fix this with robusta-light and robusta-dark in case of Light Logo and Dark Logo in the dark mode.

kranurag7 avatar Feb 21 '22 03:02 kranurag7

I question the value of telling a blind user that the logo is light or dark. I think it's more important to say "Robusta Logo" if that's what it is. If a blind user is curious, they can inspect the file name, which I imagine would tell them the fact that it's light or dark.

Note that blind users don't naturally get told the color of the rest of a web page (neither the foreground nor the background). They can inspect if they're curious, but what they generally want is a description of the meaning of the content, not the presentation of the content.

jsoref avatar Feb 21 '22 03:02 jsoref

Writing "Robusta Logo" sounds good to me too.

On Mon, 21 Feb 2022, 5:43 Josh Soref, @.***> wrote:

I question the value of telling a blind user that the logo is light or dark. I think it's more important to say "Robusta Logo" if that's what it is. If a blind user is curious, they can inspect the file name, which I imagine would tell them the fact that it's light or dark.

Note that blind users don't naturally get told the color of the rest of a web page (neither the foreground nor the background). They can inspect if they're curious, but what they generally want is a description of the meaning of the content, not the presentation of the content.

— Reply to this email directly, view it on GitHub https://github.com/robusta-dev/robusta/issues/229#issuecomment-1046443762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYUB5LJVGJGRWP2UMCVR3U4GYFRANCNFSM5O4ZVCGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

aantn avatar Feb 21 '22 03:02 aantn

Great suggestion @jsoref Let's go with Robusta Logo

kranurag7 avatar Feb 21 '22 04:02 kranurag7