robusta icon indicating copy to clipboard operation
robusta copied to clipboard

template_enricher can't handle label app.kubernetes.io/name

Open zmx opened this issue 1 year ago • 4 comments

Describe the bug K8s Pod create by Argo CD will have label app.kubernetes.io/name The KubernetesResourceEvent have that label, but string.Template.safe_substitute can't handle dot and slash

To Reproduce

$ kubectl get pod cert-manager-758c6b68ff-v2zwl -n cert-manager -o yaml
apiVersion: v1
kind: Pod
metadata:
  annotations:
    prometheus.io/path: /metrics
    prometheus.io/port: "9402"
    prometheus.io/scrape: "true"
  creationTimestamp: "2023-11-16T22:55:04Z"
  generateName: cert-manager-758c6b68ff-
  labels:
    app: cert-manager
    app.kubernetes.io/component: controller
    app.kubernetes.io/instance: cert-manager
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: cert-manager
    app.kubernetes.io/version: v1.11.2
    azure.workload.identity/use: "true"
    helm.sh/chart: cert-manager-v1.11.2

Expected behavior template could handle ${app.kubernetes.io/name}

zmx avatar Mar 01 '24 01:03 zmx

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

github-actions[bot] avatar Mar 01 '24 01:03 github-actions[bot]

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels It is Recommended Labels

zmx avatar Mar 01 '24 01:03 zmx

looks like resolved by #1389

zmx avatar Jul 21 '24 11:07 zmx

https://github.com/robusta-dev/robusta/pull/1492

zmx avatar Jul 21 '24 11:07 zmx